Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(other-api/adapter): add community adapters #5254

Merged
merged 7 commits into from
Jan 28, 2023

Conversation

penx
Copy link
Contributor

@penx penx commented Jan 25, 2023

After discussion with @machour on Discord, I have added remix-google-cloud-functions to a new "community adapters" list in the docs.

Add remix-google-cloud-functions to a new "community adapters" list.
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

⚠️ No Changeset found

Latest commit: 1ad4824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penx penx marked this pull request as draft January 25, 2023 15:18
@penx penx marked this pull request as ready for review January 25, 2023 15:25
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @penx 🎉

Left some remarks to address.

Also, not sure if that page still belongs under /other-api/, but maybe in /pages/ or /guide/.
Let's see what other think about it.

docs/other-api/adapter.md Outdated Show resolved Hide resolved
docs/other-api/adapter.md Show resolved Hide resolved
docs/pages/community.md Outdated Show resolved Hide resolved
docs/pages/community.md Outdated Show resolved Hide resolved
@machour machour added the docs label Jan 25, 2023
penx and others added 2 commits January 25, 2023 15:48
Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
@penx penx requested a review from machour January 25, 2023 15:50
docs/other-api/adapter.md Outdated Show resolved Hide resolved
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@penx penx requested review from MichaelDeBoey and removed request for machour January 25, 2023 16:54
docs/other-api/adapter.md Outdated Show resolved Hide resolved
@machour
Copy link
Collaborator

machour commented Jan 28, 2023

Spoke to Ryan, he loved the idea, thank you @penx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants