Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react router versions #5242

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Bump react router versions #5242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e37383
Bump react router versions
brophdawg11 Jan 24, 2023
58f7e1b
Remove test.fail now that RR fixes the bug
brophdawg11 Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/silent-cups-double.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@remix-run/react": patch
"@remix-run/server-runtime": patch
"@remix-run/testing": patch
---

Bump react router versions
6 changes: 0 additions & 6 deletions integration/form-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,13 +1037,7 @@ test.describe("Forms", () => {

test("sends file names when submitting via url encoding", async ({
page,
javaScriptEnabled,
}) => {
test.fail(
Boolean(javaScriptEnabled),
"<Form> doesn't handle File entries correctly when url encoding #4342"
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works correctly the newest RR release 🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenseng thank you thank you thank you


let app = new PlaywrightFixture(appFixture, page);
let myFile = fixture.projectDir + "/myfile.txt";

Expand Down
4 changes: 2 additions & 2 deletions packages/remix-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"typings": "dist/index.d.ts",
"module": "dist/esm/index.js",
"dependencies": {
"@remix-run/router": "1.3.0",
"react-router-dom": "6.7.0",
"@remix-run/router": "1.3.1-pre.0",
"react-router-dom": "6.8.0-pre.1",
"use-sync-external-store": "1.2.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/remix-server-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"typings": "dist/index.d.ts",
"module": "dist/esm/index.js",
"dependencies": {
"@remix-run/router": "1.3.0",
"@remix-run/router": "1.3.1-pre.0",
"@types/cookie": "^0.4.0",
"@types/react": "^18.0.15",
"@web3-storage/multipart-parser": "^1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/remix-testing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
"dependencies": {
"@remix-run/node": "1.11.1",
"@remix-run/react": "1.11.1",
"@remix-run/router": "1.3.0",
"@remix-run/router": "1.3.1-pre.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-router-dom": "6.7.0"
"react-router-dom": "6.8.0-pre.1"
},
"devDependencies": {
"@types/node": "^18.11.9",
Expand Down
30 changes: 15 additions & 15 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,10 +2213,10 @@
"@changesets/types" "^5.0.0"
dotenv "^8.1.0"

"@remix-run/router@1.3.0":
version "1.3.0"
resolved "https://registry.npmjs.org/@remix-run/router/-/router-1.3.0.tgz#b6ee542c7f087b73b3d8215b9bf799f648be71cb"
integrity sha512-nwQoYb3m4DDpHTeOwpJEuDt8lWVcujhYYSFGLluC+9es2PyLjm+jjq3IeRBQbwBtPLJE/lkuHuGHr8uQLgmJRA==
"@remix-run/router@1.3.1-pre.0":
version "1.3.1-pre.0"
resolved "https://registry.npmjs.org/@remix-run/router/-/router-1.3.1-pre.0.tgz#3837410c9af2f40e0aee5150ad9db27c5a2812b9"
integrity sha512-vJs8gtvb4GYBIV6zSldTrDU85UrlKVQSSoKBX0vYlidBSxcVxE5qrXRUA63DKoRO3VNv0x3eJL0qzpvaK+08Uw==

"@remix-run/web-blob@^3.0.3", "@remix-run/web-blob@^3.0.4":
version "3.0.4"
Expand Down Expand Up @@ -10398,20 +10398,20 @@ react-is@^17.0.1:
resolved "https://registry.npmjs.org/react-is/-/react-is-17.0.2.tgz"
integrity sha512-w2GsyukL62IJnlaff/nRegPQR94C/XXamvMWmSHRJ4y7Ts/4ocGRmTHvOs8PSE6pB3dWOrD/nueuU5sduBsQ4w==

react-router-dom@6.7.0:
version "6.7.0"
resolved "https://registry.npmjs.org/react-router-dom/-/react-router-dom-6.7.0.tgz#0249f4ca4eb704562b8b0ff29caeb928c3a6ed38"
integrity sha512-jQtXUJyhso3kFw430+0SPCbmCmY1/kJv8iRffGHwHy3CkoomGxeYzMkmeSPYo6Egzh3FKJZRAL22yg5p2tXtfg==
react-router-dom@6.8.0-pre.1:
version "6.8.0-pre.1"
resolved "https://registry.npmjs.org/react-router-dom/-/react-router-dom-6.8.0-pre.1.tgz#94011ddc55cbe380ca205c642a29ce5efee69808"
integrity sha512-rWwc8sZ0sai1tTU6hyivaXsuTu530yLGRFQEOSTMd861J1wJlSwuhFVrZgL2o37t78bvaJuGXO71xIuXD3717Q==
dependencies:
"@remix-run/router" "1.3.0"
react-router "6.7.0"
"@remix-run/router" "1.3.1-pre.0"
react-router "6.8.0-pre.1"

react-router@6.7.0:
version "6.7.0"
resolved "https://registry.npmjs.org/react-router/-/react-router-6.7.0.tgz#db262684c13b5c2970694084ae9e8531718a0681"
integrity sha512-KNWlG622ddq29MAM159uUsNMdbX8USruoKnwMMQcs/QWZgFUayICSn2oB7reHce1zPj6CG18kfkZIunSSRyGHg==
react-router@6.8.0-pre.1:
version "6.8.0-pre.1"
resolved "https://registry.npmjs.org/react-router/-/react-router-6.8.0-pre.1.tgz#5382f4478662c5d957230ef55aa6d881d30aa2d4"
integrity sha512-CJo6EWpNPpm7aNl+IF623zdPV6frYjLjZ75yQXQs53QJbXVgX66FL4Bduq1hsCxKtXj0EW6U/LAEmrmRu6Vsyw==
dependencies:
"@remix-run/router" "1.3.0"
"@remix-run/router" "1.3.1-pre.0"

react@^18.2.0:
version "18.2.0"
Expand Down