Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JS conversion for app code without jscodeshift #5163

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Support JS conversion for app code without jscodeshift #5163

merged 5 commits into from
Jan 20, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jan 20, 2023 •
edited
Loading

TODO

  • Update tests
  • Remove remix.env.d.ts
  • Remove any .d.ts files in app/

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a407b06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori pcattori mentioned this pull request Jan 20, 2023
Closed
1 task
@pcattori pcattori force-pushed the pedro/ts-to-js branch 2 times, most recently from c83c9ea to 76b73df Compare January 20, 2023 21:03
@pcattori pcattori marked this pull request as ready for review January 20, 2023 22:15
@pcattori pcattori merged commit 54e6cfd into dev Jan 20, 2023
@pcattori pcattori deleted the pedro/ts-to-js branch January 20, 2023 22:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 20, 2023
@machour
Copy link
Collaborator

machour commented Jan 20, 2023

Did this fix remix-run/indie-stack#182 ?

@pcattori
Copy link
Contributor Author

pcattori commented Jan 21, 2023 •
edited
Loading

@machour yes, though that was already fixed in #4891 , which I think made it into v1.9.0 late last year.

This was referenced Jan 21, 2023
Closed
Closed
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-52d60ec-20230121 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@pcattori pcattori mentioned this pull request Jan 21, 2023
Closed
andrelandgraf pushed a commit to andrelandgraf/remix that referenced this pull request Jan 22, 2023
@pcattori @andrelandgraf
Support JS conversion for app code without jscodeshift (remix-run#5163
27ce398 
)

* docs(decisions): only support js conversion for app code

* refactor(dev): remove jscodeshift-based migration

* refactor(dev): only support ts->js conversion for app code

* test(dev): update ts->js conversion tests

* test(dev): bump jest timeout for codemod test

if there's an up-to-date build, this test is fast. but if not, it can take ~15-18s locally on my M1
MBP 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcattori @machour @mcansh @MichaelDeBoey