-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(route/headers): add missing types on headers()
#5076
Conversation
I noted it misses the types over the `headers` function. Another alternative could be adding a new type `HeadersArgs` using the same conventions as for `loader` and `action`
|
Hi @irsooti, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
headers
functionheaders
function
headers
functionheaders
function
headers
functionheaders()
Thank you! |
I noted it misses the types over the
headers
function.Another alternative could be adding a new type
HeadersArgs
using the same conventions as forloader
andaction