Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(route/headers): add missing types on headers() #5076

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

irsooti
Copy link
Contributor

@irsooti irsooti commented Jan 12, 2023

I noted it misses the types over the headers function.

Another alternative could be adding a new type HeadersArgs using the same conventions as for loader and action

I noted it misses the types over the `headers` function. 

Another alternative could be adding a new type `HeadersArgs` using the same conventions as for `loader` and `action`
@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

⚠️ No Changeset found

Latest commit: b0f1985

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 12, 2023

Hi @irsooti,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 12, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@irsooti irsooti changed the title Add missing types on headers function docs: add missing types on headers function Jan 13, 2023
@machour machour changed the title docs: add missing types on headers function docs(route/headers): add missing types on headers function Jan 30, 2023
@machour machour changed the title docs(route/headers): add missing types on headers function docs(route/headers): add missing types on headers() Jan 30, 2023
@machour
Copy link
Collaborator

machour commented Jan 30, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants