Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): make entry.{client,server}.tsx optional #4600

Merged
merged 63 commits into from
Feb 10, 2023
Merged

feat(remix-dev): make entry.{client,server}.tsx optional #4600

merged 63 commits into from
Feb 10, 2023

Commits on Feb 10, 2023

  1. chore: make entry.{client,server}.tsx and root.tsx optional 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e46d08c View commit details
    Browse the repository at this point in the history

  2. chore: use absolute path 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b7df8da View commit details
    Browse the repository at this point in the history

  3. chore: require root route 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    950f699 View commit details
    Browse the repository at this point in the history

  4. feat: initial eject generator 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4d88435 View commit details
    Browse the repository at this point in the history

  5. chore: determine if streaming should be used 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ba48926 View commit details
    Browse the repository at this point in the history

  6. chore: check if entry is js, convert ts to js 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c9d11b8 View commit details
    Browse the repository at this point in the history

  7. chore: remove extra log, relative path in log 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9aa4cbf View commit details
    Browse the repository at this point in the history

  8. fix: oops 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e8a6bfa View commit details
    Browse the repository at this point in the history

  9. chore: check if any of the server/client entries exist 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    22f867c View commit details
    Browse the repository at this point in the history

  10. chore: use onAllReady for everyone by default 

    allows defer + concurrent features to work, but will still buffer the entire response

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    500d04b View commit details
    Browse the repository at this point in the history

  11. chore: set exit code 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f7e45f6 View commit details
    Browse the repository at this point in the history

  12. chore: rename to eject 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e74211d View commit details
    Browse the repository at this point in the history

  13. chore: Intl.ListFormat 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    fa1abe9 View commit details
    Browse the repository at this point in the history

  14. chore: update asset manifest to use config.entryClientFilePath 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3a39858 View commit details
    Browse the repository at this point in the history

  15. test: remove entry.{client,server} from createFixture 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e6a3a09 View commit details
    Browse the repository at this point in the history

  16. chore: check and replace runtime if non node 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    300d032 View commit details
    Browse the repository at this point in the history

  17. Update packages/remix-dev/cli/commands.ts 

    Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
    @mcansh @MichaelDeBoey
    mcansh and MichaelDeBoey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    fec99aa View commit details
    Browse the repository at this point in the history

  18. chore: add deno/cloudflare flavor of streaming 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9653bec View commit details
    Browse the repository at this point in the history

  19. chore: update deno/cloudflare server entry 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    53dac7f View commit details
    Browse the repository at this point in the history

  20. fix: rebase error 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    1c8a591 View commit details
    Browse the repository at this point in the history

  21. test: add test for user defined entry.server 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    de903ca View commit details
    Browse the repository at this point in the history

  22. chore: use array instead of set 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b32666f View commit details
    Browse the repository at this point in the history

  23. chore: add TODO 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    863af0c View commit details
    Browse the repository at this point in the history

  24. chore: remove react import 

    not needed, but does cause a `'React' refers to a UMD global, but the current file is a module. Consider adding an import instead.ts(2686)` error due to remix-dev not having a jsx tsconfig option set

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2d91b3d View commit details
    Browse the repository at this point in the history

  25. chore: remove unused type import 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c511581 View commit details
    Browse the repository at this point in the history

  26. chore: normalize console errors 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    dfa0801 View commit details
    Browse the repository at this point in the history

  27. chore: update cssBundleEntryModulePlugin entry.client to use absolute… 

    … path

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7a96641 View commit details
    Browse the repository at this point in the history

  28. test: add "@remix-run/cloudflare" to cf-compiler-test 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    74c9e90 View commit details
    Browse the repository at this point in the history

  29. chore: add abortDelay prop to <RemixServer> 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    411f437 View commit details
    Browse the repository at this point in the history

  30. chore: update cloudflare/deno default entry.server 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f5fbdac View commit details
    Browse the repository at this point in the history

  31. chore: enable new ReadableStream() via wrangler.toml 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    10fe5c3 View commit details
    Browse the repository at this point in the history

  32. chore: Apply suggestions from code review 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    37f80ed View commit details
    Browse the repository at this point in the history

  33. chore: update default node entry.server 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a9c290a View commit details
    Browse the repository at this point in the history

  34. chore: add signal to cf/deno entry.server 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    167c32a View commit details
    Browse the repository at this point in the history

  35. chore: use appDirectory from config 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    eaf34ca View commit details
    Browse the repository at this point in the history

  36. chore: dont exit 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ed444d4 View commit details
    Browse the repository at this point in the history

  37. chore(cssBundleEntryModulePlugin): use relative path so builds stay d… 

    …eterministic

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    db80c70 View commit details
    Browse the repository at this point in the history

  38. chore: warn when isbot is not installed 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b0fee68 View commit details
    Browse the repository at this point in the history

  39. chore: export transpile fn 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a5202ff View commit details
    Browse the repository at this point in the history

  40. fix: filename is the filename 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e92e3dd View commit details
    Browse the repository at this point in the history

  41. test: add tests and fixtures for eject 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e635dc6 View commit details
    Browse the repository at this point in the history

  42. chore: dont auto install isbot as that breaks e2e tests 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ceee1c1 View commit details
    Browse the repository at this point in the history

  43. chore: lint 

    [skip ci]

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4fc7e15 View commit details
    Browse the repository at this point in the history

  44. Revert "chore: dont auto install isbot as that breaks e2e tests" 

    This reverts commit 7e17173.
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9f5da53 View commit details
    Browse the repository at this point in the history

  45. chore: add isbot to e2e tests 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    60102e2 View commit details
    Browse the repository at this point in the history

  46. chore: add isbot to e2e tests 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0c42048 View commit details
    Browse the repository at this point in the history

  47. Create heavy-jars-accept.md

    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    cc79d61 View commit details
    Browse the repository at this point in the history

  48. fix: add isbot 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3dda83b View commit details
    Browse the repository at this point in the history

  49. chore: update changeset 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d44fb6f View commit details
    Browse the repository at this point in the history

  50. chore: update cloudflare workers entry.server to use streaming 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    94df96f View commit details
    Browse the repository at this point in the history

  51. chore: "err" -> "error"; remove "didError" 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c0d82f2 View commit details
    Browse the repository at this point in the history

  52. chore: "err" -> "error"; remove "didError" 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    74e48e3 View commit details
    Browse the repository at this point in the history

  53. fix: generating js entry 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    29f1d4b View commit details
    Browse the repository at this point in the history

  54. chore: rename to reveal ✨ 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d77d3ad View commit details
    Browse the repository at this point in the history

  55. fix: make remixRoot the second arg 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b832493 View commit details
    Browse the repository at this point in the history

  56. feat: anticipate other client runtimes 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    86a5d0f View commit details
    Browse the repository at this point in the history

  57. chore: add todo 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    41ec8f0 View commit details
    Browse the repository at this point in the history

  58. test: update for c6f8761 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    86871d1 View commit details
    Browse the repository at this point in the history

  59. fixup! feat: anticipate other client runtimes

    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9d7b523 View commit details
    Browse the repository at this point in the history

  60. chore: flip if..else for user defined entry files 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    23fd35b View commit details
    Browse the repository at this point in the history

  61. fix 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    33d797b View commit details
    Browse the repository at this point in the history

  62. chore(reveal): only support entry.client or entry.server, use flag fo… 

    …r no ts; attempt to create both entries if no entry supplied

Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    282ce35 View commit details
    Browse the repository at this point in the history

  63. test: update snapshot, tweak test to use updated name, add js version 

    Signed-off-by: Logan McAnsh <logan@mcan.sh>
    @mcansh
    mcansh committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a7661fc View commit details
    Browse the repository at this point in the history