Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(remix-dev): rewrite
jscodeshift
-based migrations asbabel
-based codemods #4572refactor(remix-dev): rewrite
jscodeshift
-based migrations asbabel
-based codemods #4572Changes from all commits
7bf9425
a6b800d
474e80f
c4cef84
0e2c0b6
a0e0dca
a6ce326
e58d1d3
fd5742f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a good idea to keep this file in line with our templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remix automatically adds these lines to the tsconfig if they are missing, which adds noise to the console for tests. So just decied to include it here since we enforce it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know Remix automatically adds these.
That's why our templates have these values in
tsconfig.json
by default.What I was suggesting was: copy over the
tsconfig.json
from one of our templates, so it's easier to auto-update (find/replace) if ever neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see! I do like the isolation of fixtures being self-contained, but also like your suggestion as well. Let me think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean to copy over the file automatically, just copying over the content manually
So if we ever have to add extra defaults, we can just do all files automatically & we don't have to think about this file being different