Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-server-runtime): RRR 1.2 - handleDataRequest #4359

Merged
merged 13 commits into from
Oct 17, 2022

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Oct 12, 2022

decision doc

Part 2 of step 1 in layering Remix back on top of React Router now that we have released @remix-run/router.

Changes:

  • Implement handleDataRequest on top of RR alongside existing implementation

Closes: #

  • Docs
  • Tests

Testing Strategy:

Assert that existing tests pass and manually check new code is not in non-experimental production builds.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: 4e9eb88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/node Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/react Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
create-remix Patch
@remix-run/serve Patch
remix Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.eslintignore Outdated Show resolved Hide resolved
@brophdawg11
Copy link
Contributor

Note: handleResourceRouteRR should not pass a routeId to queryRoute so we get proper ?index handling

chore: make action optional again and utilize latest router feature
@jacob-ebey
Copy link
Member Author

Note: handleResourceRouteRR should not pass a routeId to queryRoute so we get proper ?index handling

Let's revisit this outside of this PR. I believe there is a behavior mismatch here we need to resolve.

@jacob-ebey jacob-ebey merged commit 237a289 into dev Oct 17, 2022
@jacob-ebey jacob-ebey deleted the rrr-data-requests branch October 17, 2022 23:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3e4e7e6-20221018 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants