fix(remix-dev): make MDX builds deterministic #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 354924c The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is a fix along the lines of remix-run#2027; because the MDX virtual modules resolve to absolute paths, the manifest/hashes/etc. differ based on the parent directory structure. Testing notes: 1. Expanded existing integration test to cover this scenario (fails without the fix). Also add other virtual module scenarios that weren't already covered 2. Validated in a real MDX Remix app that has split client / server builds (applied fix via patch-package)
jenseng
force-pushed
the
fix-mdx-hashing
branch
from
f9845a7
to
354924c
Compare
MichaelDeBoey
requested review from
ryanflorence,
machour,
mjackson,
chaance and
kentcdodds
kentcdodds
approved these changes
Aug 8, 2022
MichaelDeBoey
added
the
awaiting release
mcansh
pushed a commit
that referenced
this pull request
Aug 11, 2022
This was referenced Aug 12, 2022
MichaelDeBoey
removed
the
awaiting release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix along the lines of #2027; because the MDX virtual modules resolve to absolute paths, the manifest/hashes/etc. differ based on the parent directory structure.
Refs: #2024
Testing Strategy: