Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/envvars): update @remix-run/cloudflare-pages docs #3804

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

awthwathje
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2022

⚠️ No Changeset found

Latest commit: 1f9cac3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 20, 2022

Hi @awthwathje,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Copy link
Contributor Author

@awthwathje awthwathje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only the --binding $(cat .env) trick doesn't work in PowerShell, there is an official way to achieve the same result.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 20, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@awthwathje awthwathje changed the title fix: update docs, since CF Functions use a different file for local env variables. docs(envvars): update docs, since CF Functions use a different file for local env variables. Jul 20, 2022
@MichaelDeBoey MichaelDeBoey changed the title docs(envvars): update docs, since CF Functions use a different file for local env variables. docs(guides/envvars): update @remix-run/cloudflare-pages docs Jul 20, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 1c96c07 into remix-run:main Jul 20, 2022
@awthwathje
Copy link
Contributor Author

Wow, Kent C. Dodds himself merged my little PR. That's pretty cool! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants