Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(faq): Fix the mismatch between the button value and the expected value in the switch #3788

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

jasonadelia
Copy link
Contributor

While reviewing the FAQs around multiple forms in one route I noticed this mismatch in the values. The case in the switch is looking for update while the button value was create.

  • Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2022

⚠️ No Changeset found

Latest commit: 8a3e44b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 18, 2022

Hi @jasonadelia,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 18, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 650ce58 into remix-run:main Jul 18, 2022
@jasonadelia
Copy link
Contributor Author

Thanks!

Thank you all for Remix 🥳

dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants