Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tutorials): update Node requirement #3787

Merged
merged 1 commit into from
Jul 18, 2022
Merged

docs(tutorials): update Node requirement #3787

merged 1 commit into from
Jul 18, 2022

Conversation

MichaelDeBoey
Copy link
Member

Remix doesn't support Node v12

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2022

⚠️ No Changeset found

Latest commit: f35745a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@machour
Copy link
Collaborator

machour commented Jul 18, 2022

Related to #3658

machour
machour approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do indeed specify it in our package.json files:

  "engines": {
    "node": ">=14"
  }

docs/tutorials/blog.md Show resolved Hide resolved
kentcdodds
kentcdodds approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kentcdodds kentcdodds merged commit b3735f6 into remix-run:main Jul 18, 2022
@MichaelDeBoey MichaelDeBoey deleted the update-tutorial-node-requirement branch July 18, 2022 15:13
dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
@MichaelDeBoey @dvargas92495
docs(tutorials): update Node requirement (remix-run#3787)
ee08a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

@mcansh mcansh Awaiting requested review from mcansh

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @machour @kentcdodds