Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-eslint-config): use require.resolve when importing @babel/preset-react #3716

Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix(remix-eslint-config): use require.resolve when importing @babel/preset-react #3716

merged 2 commits into from
Jul 13, 2022

Conversation

kiancross
Copy link
Contributor

@kiancross kiancross commented Jul 12, 2022

Closes: #3715

  • Docs
  • Tests

Testing Strategy:

  1. In a new directory run yarn init -2.
  2. Then run yarn add -D eslint @remix-run/eslint-config.
  3. Create a file called .eslintrc with the following:
{
  "extends": [ "@remix-run/eslint-config" ]
}
  1. Create a file called test.js with the following:
eslint_Wont_like_This = true
  1. Run yarn eslint test.js.
  2. Ensure that the output is an ESlint problem and not a Yarn error (as shown in remix-eslint-config throws an error when using Yarn PnP #3715).

I attempted to write an automated test, however, I couldn't find any preexisting ones for this package, so I didn't have anything to go off.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: 2e6f92b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/eslint-config Patch
@remix-run/dev Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/node Patch
@remix-run/deno Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
create-remix Patch
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 12, 2022

Hi @kiancross,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 12, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 💖 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants