Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): remove hardcoded links export from MDX compiler #3424

Closed
wants to merge 2 commits into from
Closed

fix(remix-dev): remove hardcoded links export from MDX compiler #3424

wants to merge 2 commits into from

Conversation

andreiduca
Copy link
Contributor

Proposed fix for #3423.

I see this was added back in https://github.com/remix-run/remix/pull/254/files#diff-38dea30b5d212ef5a7a272ce3b9945d971604deb632155b47ebf6676cb8e570aR47 but the changes seem unrelated to the PR's intent. Wondering why it was originally added. The discussion around it also seems misleading, as removing that line like in this proposed PR seems to be providing the expected result.

But I'm most likely missing something, so opening this up for discussion.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2022

Hi @andreiduca,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@andreiduca andreiduca changed the base branch from main to dev June 9, 2022 15:32
@andreiduca andreiduca changed the base branch from dev to main June 9, 2022 15:33
@andreiduca andreiduca changed the base branch from main to dev June 9, 2022 15:37
@machour machour linked an issue Jun 10, 2022 that may be closed by this pull request
@machour
Copy link
Collaborator

machour commented Jul 16, 2022

Thank you so much for your contribution @andreiduca!

I'm going to close this one in favor of #3763 which adds support for links, handle and meta altogether. Feel free to chime in there!

@machour machour closed this Jul 16, 2022
@MichaelDeBoey MichaelDeBoey added the duplicate This issue or pull request already exists label Jul 16, 2022
@andreiduca andreiduca deleted the patch-1 branch July 20, 2022 19:54
@kentcdodds
Copy link
Member

Sorry I missed this PR. Thanks for working on it @andreiduca! You'll be pleased to know that the next release of Remix will have this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed duplicate This issue or pull request already exists feat:mdx package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting links function doesn't work in MDX files
4 participants