Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev/cli): add DX improvements for migrate command & replace-remix-imports migration #2670

Merged
merged 31 commits into from
Apr 12, 2022
Merged

feat(remix-dev/cli): add DX improvements for migrate command & replace-remix-imports migration #2670

merged 31 commits into from
Apr 12, 2022

Commits on Apr 12, 2022

  1. refactor(cli/migrate): remove "client" terminology 

    better term might be "renderer" (note that renderers run in both client and server). since we only
support react so far, the migration doesn't need any general terminology anyway.
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    92806cf View commit details
    Browse the repository at this point in the history

  2. refactor(cli/migrate): reuse Flag type

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    5503f17 View commit details
    Browse the repository at this point in the history

  3. fix(cli/migrate): only show jscodeshift args when --debug flag is set

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    cca42d7 View commit details
    Browse the repository at this point in the history

  4. refactor(cli/migrate): make adapter option optional for `replace-re… 

    …mix-imports` transform
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    5756be3 View commit details
    Browse the repository at this point in the history

  5. feat(cli/migrate): improve runtime/adapter resolution for `replace-re… 

    …mix-imports` migration
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    f40c42b View commit details
    Browse the repository at this point in the history

  6. chore(cli/migrate): silence warnings about mixing default/named expor… 

    …ts in transformations

by design, transformations have a default export for compatibility with jscodeshift. but we also
want to share code from transforms, necessitating named exports.
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    8080bb1 View commit details
    Browse the repository at this point in the history

  7. feat(cli/migrate): do not modify user's package.json, instead ask t… 

    …hem to do post-migration steps

also, improved DX by clearly delineating separate migration sections
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2bf5f20 View commit details
    Browse the repository at this point in the history

  8. refactor(cli/migrate): check git status as soon as possible

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    45558e6 View commit details
    Browse the repository at this point in the history

  9. test(cli): add --debug flag for migrate command in tests

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    928d1af View commit details
    Browse the repository at this point in the history

  10. refactor(cli/migrate): combine imports from same module

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    11bdc74 View commit details
    Browse the repository at this point in the history

  11. feat(cli/migrate): auto-detect node runtime if @remix-run/serve i… 

    …s a dependency
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    87a6a47 View commit details
    Browse the repository at this point in the history

  12. feat(cli/migrate): show npm commands for manual steps in `replace-r… 

    …emix-imports` migration
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    c57111a View commit details
    Browse the repository at this point in the history

  13. feat(cli/migrate): handle remix setup without runtime arg in `repla… 

    …ce-remix-imports`
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    6553122 View commit details
    Browse the repository at this point in the history

  14. feat(cli/migrate): auto-detect server runtime from presence of server… 

    … adapter
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    6a38e76 View commit details
    Browse the repository at this point in the history

  15. feat(cli/migrate): automatically update package.json

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    9a04568 View commit details
    Browse the repository at this point in the history

  16. refactor(cli/migrate): convenience function for resolving general all… 

    … migration inputs
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    c4d0481 View commit details
    Browse the repository at this point in the history

  17. feat(cli/migrate): user-friendly cli output for replace-remix-imports

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    4372234 View commit details
    Browse the repository at this point in the history

  18. refactor(cli/migrate): remove unused import

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    5dc8c6a View commit details
    Browse the repository at this point in the history

  19. refactor(cli/migrate): explicit type for adapterToRuntime converter

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    048f26e View commit details
    Browse the repository at this point in the history

  20. refactor(cli/migrate): remove redundant check for migration id

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    b262977 View commit details
    Browse the repository at this point in the history

  21. refactor(cli/migrate): explicitly type detectedRuntime utility with… 

    … `Runtime` arg
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    659c6a3 View commit details
    Browse the repository at this point in the history

  22. test(cli/migrate): replace-remix-imports runs successfully on (old)… 

    … blog tutorial example
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    738f414 View commit details
    Browse the repository at this point in the history

  23. style: ignore test fixtures

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    6d8bcea View commit details
    Browse the repository at this point in the history

  24. chore(dev): remove reference to non-existant @mdx-js/mdx types

    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    d6a7181 View commit details
    Browse the repository at this point in the history

  25. refactor(cli/migrate): ignore missing types for @npmcli/package-json 

    once DefinitelyTyped/DefinitelyTyped#59806 is merged, we can install
`@types/@npmcli/package-json` instead
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    053b8f8 View commit details
    Browse the repository at this point in the history

  26. fix(cli/migrate): only print colorful output if terminal supports it … 

    …and wants it
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    a2495ab View commit details
    Browse the repository at this point in the history

  27. test(cli/migrate): check that replace-remix-imports remove all `rem… 

    …ix` imports
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    a6b98d0 View commit details
    Browse the repository at this point in the history

  28. fix(cli/migrate): replace-remix-imports ensures @remix-run/dev is… 

    … a dev dependency
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    96e5bfe View commit details
    Browse the repository at this point in the history

  29. fix(cli/migrate): package.json already exists, so refer to it as "upd… 

    …ated", not "new"
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    1c9051b View commit details
    Browse the repository at this point in the history

  30. refactor(cli/migrate): separate transform-related exports from the tr… 

    …ansform

because jscodeshift does not have full typescript support for transforms
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    6a7a688 View commit details
    Browse the repository at this point in the history

  31. fix(cli/migrate): fix all jscodeshift non-supported typescript syntax… 

    … in transform

see facebook/jscodeshift#467
    @pcattori
    pcattori committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    6963bcb View commit details
    Browse the repository at this point in the history