fix(remix-node): update @remix-run/web-fetch to 4.3.2 (#4644)

remix-run · Nov 18, 2022 · 761f2f7 · 761f2f7
1 parent 848d8b0
commit 761f2f7
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 5 deletions.
diff --git a/.changeset/moody-cats-relax.md b/.changeset/moody-cats-relax.md
@@ -0,0 +1,9 @@
+---
+"remix": patch
+"@remix-run/node": patch
+---
+
+chore: update @remix-run/web-fetch to 4.3.2
+
+-  fix: Memory leak caused by unregistered listeners. Solution was copied from a node-fetch pr.
+-  fix: Add support for custom "credentials" value. Nothing is done with them at the moment but they pass through for the consumer of the request to access if needed.
diff --git a/packages/remix-architect/__tests__/server-test.ts b/packages/remix-architect/__tests__/server-test.ts
@@ -284,6 +284,7 @@ describe("architect createRemixRequest", () => {
           "type": null,
         },
         Symbol(Request internals): Object {
+          "credentials": "same-origin",
           "headers": Headers {
             Symbol(query): Array [
               "accept",

diff --git a/packages/remix-express/__tests__/server-test.ts b/packages/remix-express/__tests__/server-test.ts
@@ -254,6 +254,7 @@ describe("express createRemixRequest", () => {
           "type": null,
         },
         Symbol(Request internals): Object {
+          "credentials": "same-origin",
           "headers": Headers {
             Symbol(query): Array [
               "cache-control",

diff --git a/packages/remix-netlify/__tests__/server-test.ts b/packages/remix-netlify/__tests__/server-test.ts
@@ -267,6 +267,7 @@ describe("netlify createRemixRequest", () => {
           "type": null,
         },
         Symbol(Request internals): Object {
+          "credentials": "same-origin",
           "headers": Headers {
             Symbol(query): Array [
               "cookie",

diff --git a/packages/remix-node/package.json b/packages/remix-node/package.json
@@ -16,7 +16,7 @@
   "sideEffects": false,
   "dependencies": {
     "@remix-run/server-runtime": "1.7.6",
-    "@remix-run/web-fetch": "^4.3.1",
+    "@remix-run/web-fetch": "^4.3.2",
     "@remix-run/web-file": "^3.0.2",
     "@remix-run/web-stream": "^1.0.3",
     "@web3-storage/multipart-parser": "^1.0.0",

diff --git a/packages/remix-vercel/__tests__/server-test.ts b/packages/remix-vercel/__tests__/server-test.ts
@@ -259,6 +259,7 @@ describe("vercel createRemixRequest", () => {
           "type": null,
         },
         Symbol(Request internals): Object {
+          "credentials": "same-origin",
           "headers": Headers {
             Symbol(query): Array [
               "cache-control",

diff --git a/yarn.lock b/yarn.lock
@@ -2255,10 +2255,10 @@
     "@remix-run/web-stream" "^1.0.0"
     web-encoding "1.1.5"
 
-"@remix-run/web-fetch@^4.3.1":
-  version "4.3.1"
-  resolved "https://registry.npmjs.org/@remix-run/web-fetch/-/web-fetch-4.3.1.tgz"
-  integrity sha512-TOpuJo3jI7/qJAY0yTnvNJRQl4hlWAOHUHYKAbEddcLFLydv+0/WGT6OaIurJKsBFJJTjooe3FbKiP74sUIB/g==
+"@remix-run/web-fetch@^4.3.2":
+  version "4.3.2"
+  resolved "https://registry.npmjs.org/@remix-run/web-fetch/-/web-fetch-4.3.2.tgz#193758bb7a301535540f0e3a86c743283f81cf56"
+  integrity sha512-aRNaaa0Fhyegv/GkJ/qsxMhXvyWGjPNgCKrStCvAvV1XXphntZI0nQO/Fl02LIQg3cGL8lDiOXOS1gzqDOlG5w==
   dependencies:
     "@remix-run/web-blob" "^3.0.4"
     "@remix-run/web-form-data" "^3.0.3"