Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the tutorial on https://reactrouter.com/ #9916

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

jdufresne
Copy link
Contributor

The raw MarkDown is less styled and has broken image files. The documents are intended to be read on https://reactrouter.com/ so link there to be more friendly to newcomers.

Fixes #9607

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2023

⚠️ No Changeset found

Latest commit: 9aa9b69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 17, 2023

Hi @jdufresne,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

The raw MarkDown is less styled and has broken image files. The
documents are intended to be read on https://reactrouter.com/ so link
there to be more friendly to newcomers.

Fixes remix-run#9607
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 17, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Jan 17, 2023

Thank you!

@timdorr timdorr merged commit fe44d73 into remix-run:main Jan 17, 2023
@jdufresne jdufresne deleted the readme-tutorial branch January 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: the image on the line 10 of the tutorial page is broken
2 participants