Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for optional path segments in matchPath #10765

Closed
wants to merge 2 commits into from
Closed

Added support for optional path segments in matchPath #10765

wants to merge 2 commits into from

Conversation

imjordanxd
Copy link
Contributor

@imjordanxd imjordanxd commented Aug 7, 2023

Overview

Adds support for optional path segments in matchPath. Resolves #9862

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

⚠️ No Changeset found

Latest commit: 142b42c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 7, 2023

Hi @imjordanxd,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@imjordanxd imjordanxd changed the title Added support for optional paths in matchPath Added support for optional segments in matchPath Aug 7, 2023
@imjordanxd imjordanxd changed the title Added support for optional segments in matchPath Added support for optional path segments in matchPath Aug 7, 2023
@imjordanxd imjordanxd changed the base branch from main to dev August 8, 2023 14:21
@imjordanxd imjordanxd changed the base branch from dev to main August 8, 2023 14:21
@imjordanxd imjordanxd closed this by deleting the head repository Aug 8, 2023
@imjordanxd
Copy link
Contributor Author

imjordanxd commented Aug 8, 2023

restarting this as I misread the contributing guides - follow #10768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant