Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] console report errors in react-router@3.0.4 #4943

Closed
wssgcg1213 opened this issue Apr 10, 2017 · 6 comments
Closed

[V3] console report errors in react-router@3.0.4 #4943

wssgcg1213 opened this issue Apr 10, 2017 · 6 comments

Comments

@wssgcg1213
Copy link

Version

3.0.4

I updated my react-router from 3.0.2 to 3.0.4.

image

it works fine in 3.0.2.

ref: https://facebook.github.io/react/warnings/dont-call-proptypes.html

@wssgcg1213
Copy link
Author

wssgcg1213 commented Apr 10, 2017

which change cause these errors and how do i fix it?
thanks~

@krisaoe
Copy link

krisaoe commented Apr 10, 2017

These warnings are caused by the changes to React v.15.5.0, as they are splitting PropTypes into a separate package. I imagine react-router will fix this soon.
Apologies, I misread your warning. Your's is different to mine!
You can read more about the changes and reasoning here https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

@wssgcg1213
Copy link
Author

@krisaoe thx, but my react version is 15.1.0.
I guess it is related to
https://github.com/ReactTraining/react-router/blob/c904dcccd676883103ee7f8d3e9b3dc9a8918359/modules/ContextUtils.js#L1

prop-types@^15.5.6
https://github.com/ReactTraining/react-router/blob/c904dcccd676883103ee7f8d3e9b3dc9a8918359/package.json#L41

I have no plan to update react to 15.5 yet, will react-router fix it?

@wssgcg1213
Copy link
Author

wssgcg1213 commented Apr 10, 2017

I update my react to 15.3.2 and fix this problem.

@wssgcg1213
Copy link
Author

sorry, I misread my page, it is still a lot of warnings in Console

@wssgcg1213 wssgcg1213 reopened this Apr 10, 2017
@timdorr
Copy link
Member

timdorr commented Apr 10, 2017

This was specifically fixed here: #3591

If something is running your PropType validations manually, it's not us.

@timdorr timdorr closed this as completed Apr 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants