Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths with multiple *s should cause warning #318

Closed
appsforartists opened this issue Sep 26, 2014 · 2 comments
Closed

paths with multiple *s should cause warning #318

appsforartists opened this issue Sep 26, 2014 · 2 comments

Comments

@appsforartists
Copy link

For curiosity's sake, I tested what would happen if you had this path:

  <Route
    path    = "/example/:keyName/*/*/"

and tried to transitionTo it. Splat gets put in twice:

http://localhost:8080/example/4025675/grandpa%2Cmom%2Cme/grandpa%2Cmom%2Cme/

Since that is most likely gibberish, developers who use multiple *s should be warned that this makes the correct resolution of transitionTo ambiguous.

@appsforartists
Copy link
Author

This may have been fixed in the latest builds. See #317.

@ryanflorence
Copy link
Member

I'd have to see what your transitionTo looks like, but the router will throw an error if you don't give it enough splats.

New spec: 9a265b3

Let me know if you think this should be reopened.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants