Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-router transitively requires react-dom #2048

Closed
steveorsomethin opened this issue Sep 22, 2015 · 1 comment
Closed

react-router transitively requires react-dom #2048

steveorsomethin opened this issue Sep 22, 2015 · 1 comment

Comments

@steveorsomethin
Copy link

See facebook/react#4938

As mentioned there, there was some informal discussion (I think via twitter, I can dig it up) about evaluating react-router around a React implementation, and just defaulting to react-dom. That was rejected since we were expecting 0.14 to fully separate core from dom. Is parameterizing an implementation something you'd be willing to take a PR on? I don't expect it would affect the public interface at all, and would enable react-native to work as well.
@mjackson
Copy link
Member

Looks like there's already a PR in #2031. Let's discuss there.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjackson @steveorsomethin