Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Future flag warning for v7_relativeSplatPath even when it's set #13006

Open
porluz opened this issue Feb 12, 2025 · 0 comments
Open

[Bug]: Future flag warning for v7_relativeSplatPath even when it's set #13006

porluz opened this issue Feb 12, 2025 · 0 comments
Labels

Comments

@porluz
Copy link

porluz commented Feb 12, 2025

I'm using React Router as a...

library

Reproduction

In version 6.29, even when the future flag v7_relativeSplatPath is set to false, a warning is still logged.

Instead of a falsy check, and undefined check would get rid of the warning when v7_relativeSplatPath is set to false.

Existing check:

  if ((renderFuture == null ? void 0 : renderFuture.v7_relativeSplatPath) === undefined && (!routerFuture || !routerFuture.v7_relativeSplatPath)) {
    logDeprecation("v7_relativeSplatPath", "Relative route resolution within Splat routes is changing in v7", "https://reactrouter.com/v6/upgrading/future#v7_relativesplatpath");
  }

System Info

System:
    OS: macOS 15.2
    CPU: (12) arm64 Apple M2 Max
    Memory: 719.77 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.14.0 - ~/.nvm/versions/node/v20.14.0/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.14.0/bin/npm
  Browsers:
    Chrome: 133.0.6943.54
    Safari: 18.2

Used Package Manager

npm

Expected Behavior

No future warning is logged when v7_relativeSplatPath is set to false

Actual Behavior

A future warning is logged when v7_relativeSplatPath is set to false

@porluz porluz added the bug label Feb 12, 2025
@porluz porluz changed the title [Bug]: Too many v7 warnings [Bug]: Future flag warning for v7_relativeSplatPath even when it's set Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant