Fix hash test

remix-run · Jan 4, 2023 · 94efa1a · 94efa1a
1 parent b519bb3
commit 94efa1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react-router-dom/__tests__/data-browser-router-test.tsx b/packages/react-router-dom/__tests__/data-browser-router-test.tsx
@@ -4263,7 +4263,7 @@ function createDeferred() {
 
 function getWindowImpl(initialUrl: string, isHash = false): Window {
   // Need to use our own custom DOM in order to get a working history
-  const dom = new JSDOM(`<!DOCTYPE html>`, { url: "https://remix.run/" });
+  const dom = new JSDOM(`<!DOCTYPE html>`, { url: "http://localhost/" });
   dom.window.history.replaceState(null, "", (isHash ? "#" : "") + initialUrl);
   return dom.window as unknown as Window;
 }

diff --git a/packages/router/history.ts b/packages/router/history.ts
@@ -640,7 +640,7 @@ function getUrlBasedHistory(
         ? window.location.origin
         : window.location.href;
 
-    let href = createHref(window, to);
+    let href = typeof to === "string" ? to : createPath(to);
     invariant(
       base,
       `No window.location.(origin|href) available to create URL for href: ${href}`