Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Cypress typecheck #194

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: fix Cypress typecheck #194

merged 1 commit into from
Jun 30, 2023

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 25, 2023 •
edited
Loading

@MoSattler
Copy link

Hi @MichaelDeBoey - I think you're trying to solve the same problem as me in #193 - but your approach might be cleaner.

@MoSattler MoSattler mentioned this pull request Jun 25, 2023
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 26, 2023
Closed
@MichaelDeBoey MichaelDeBoey merged commit 659fca0 into remix-run:main Jun 30, 2023
6 checks passed
@MichaelDeBoey MichaelDeBoey deleted the fix-typecheck branch June 30, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run typecheck fails on fresh project
3 participants
@MichaelDeBoey @MoSattler @brophdawg11