Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support links to private repos #49

Closed
4 tasks done
nkakouros opened this issue Aug 15, 2024 · 4 comments
Closed
4 tasks done

Support links to private repos #49

nkakouros opened this issue Aug 15, 2024 · 4 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@nkakouros
Copy link

Initial checklist

Problem

I have a link in my README that points to the wiki of a private repo, e.g. https://github.com/remarkjs/remark-lint-no-dead-urls/wiki. This link is reported as dead.

Solution

It would be nice to have the option to supply a github token or a general authentication token to be used when accessing urls.

Alternatives

The only alternative is to blacklist the private repo.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 15, 2024
@wooorm
Copy link
Member

wooorm commented Aug 15, 2024

I don't see how; this project isn't specific to GH, but the entire web. You'd need to allow tokens and login flows for all websites ever.
Instead: this seems quite logical. Other people who would view your readme would not be able to see that page either.
I'd recommend not linking to it.
Or if you do, you'd have to ignore it, and should likely write it text that it is private?

@nkakouros
Copy link
Author

I see. I'll probably add a skip pattern for these links.

This comment was marked as resolved.

@wooorm wooorm added 🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on labels Aug 16, 2024

This comment was marked as resolved.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants