From 9ec5ba146cf077c2757b24d9626d649f8a63676e Mon Sep 17 00:00:00 2001 From: ssi02014 Date: Thu, 10 Aug 2023 04:12:46 +0900 Subject: [PATCH] fix(utilities): fix ELEMENTS_WITH_NO_TEXT_CHILDREN naming --- lib/utilities.js | 6 +++--- test/utilities.test.js | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/utilities.js b/lib/utilities.js index f6033b1f..7d17dfab 100644 --- a/lib/utilities.js +++ b/lib/utilities.js @@ -99,7 +99,7 @@ var PRESERVE_CUSTOM_ATTRIBUTES = React.version.split('.')[0] >= 16; // Taken from // https://github.com/facebook/react/blob/cae635054e17a6f107a39d328649137b83f25972/packages/react-dom/src/client/validateDOMNesting.js#L213 -var ELEMENTS_WITH_TEXT_CHILDREN = new Set([ +var ELEMENTS_WITH_NO_TEXT_CHILDREN = new Set([ 'tr', 'tbody', 'thead', @@ -118,7 +118,7 @@ var ELEMENTS_WITH_TEXT_CHILDREN = new Set([ * @returns - Whether node can contain text nodes. */ function canTextBeChildOfNode(node) { - return !ELEMENTS_WITH_TEXT_CHILDREN.has(node.name); + return !ELEMENTS_WITH_NO_TEXT_CHILDREN.has(node.name); } function returnFirstArg(arg) { @@ -127,7 +127,7 @@ function returnFirstArg(arg) { module.exports = { PRESERVE_CUSTOM_ATTRIBUTES: PRESERVE_CUSTOM_ATTRIBUTES, - ELEMENTS_WITH_TEXT_CHILDREN: ELEMENTS_WITH_TEXT_CHILDREN, + ELEMENTS_WITH_NO_TEXT_CHILDREN: ELEMENTS_WITH_NO_TEXT_CHILDREN, invertObject: invertObject, isCustomComponent: isCustomComponent, setStyleProp: setStyleProp, diff --git a/test/utilities.test.js b/test/utilities.test.js index ff553ed5..029646b0 100644 --- a/test/utilities.test.js +++ b/test/utilities.test.js @@ -1,7 +1,7 @@ const React = require('react'); const { PRESERVE_CUSTOM_ATTRIBUTES, - ELEMENTS_WITH_TEXT_CHILDREN, + ELEMENTS_WITH_NO_TEXT_CHILDREN, invertObject, isCustomComponent, setStyleProp, @@ -141,7 +141,7 @@ describe('setStyleProp', () => { }); describe('canTextBeChildOfNode', () => { - it.each(Array.from(ELEMENTS_WITH_TEXT_CHILDREN))( + it.each(Array.from(ELEMENTS_WITH_NO_TEXT_CHILDREN))( 'returns false since text node cannot be child of %s', nodeName => { const node = {