Use non-minified Soundmanager #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bar-ui-min.js is not even used anywhere and the size of soundmanager2.js does not really matter because it will almost always be cached by browser.
In case the AP page is not yet cached the file size difference is 13kB vs 45kB.
For the whole page that makes 1.09MB vs 1.12MB—gzip on, measured for Artists view. The relative difference will be even less significant for views with pictures and most importantly, chasing kilobytes is completely inconsequential once audio streaming starts.
The minified code is impossible to debug and not worth the hassle when modifications have to be made.