-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show song info in title #393
Conversation
Hello, the reason against LET is the compatibility. |
2nd version |
are you referring to something like this? |
Yes, pretty much. Just like in any other language pick one thing and stick with it. Does not mattern what you pick in the end, as long as you are consistent. If you use a style that is commonly known and accepted even better. Even better than that, use eslint and push eslint config file in your repo so anyone can see in their IDEs what you want. You might have to tweak the file a bit since you use jQuery. |
Hi, I wrote this basically one-liner feature and did some light refactoring and fixing along the way, so I would not have to duplicate code.
You may not want the last commit as I did not see you using let, const or template literals anywhere in JS, but I don't know whether you are actively avoiding them or just not used to using them.