Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 compatibility #449

Closed
snarffy1959 opened this issue Dec 6, 2019 · 9 comments
Closed

PHP 7.4 compatibility #449

snarffy1959 opened this issue Dec 6, 2019 · 9 comments
Assignees
Milestone

Comments

@snarffy1959
Copy link

Actual behavior

Nextcloud or some of the used apps recommended to use the latest version of PHP (at this moment 7.4) so i installed this version. After that I liked to download and install Audio Player but that was not possible anymore because of this "PHP with a version lower than 7.3 is required.".

Steps to reproduce the behavior

  1. Select Audio player in Nextcloud

Additional information (optional)

Prerequisites  
Prerequisite Nextcloud versions >=14.0.0,<18.0.0
Minimum Integer bits 32
PHP >=7.0.0,<7.4.0

Server configuration

Operating system:

Web server:

Database:

Nextcloud/ownCloud version: (see /status.php)
17.0.1

Audio Player version: (see /settings/apps)
2.8.4

Are you using external storage? If yes, which one: local/smb/sftp/...

Client configuration

Browser:

Logs

Nextcloud/ownCloud log

Nextcloud/ownCloud log (`/data/[nextcloud|owncloud].log`)
Insert your Nextcloud/ownCloud log here

Web server error log (optional)

Web server error log
Insert your web server log here

Browser log (optional)

Browser log
Insert your browser log here
@Rello Rello self-assigned this Dec 7, 2019
@Rello
Copy link
Owner

Rello commented Dec 7, 2019

Hello,
I don´t have a 7.4 environment ready yet. do you have the possibility to maintain the info.xml manually to include 7.4 and let me know if AP still works?

@snarffy1959
Copy link
Author

Hello Rello thanx for your reply, it took me a while (never add apps in nextcloud by hand). I think its working with FireFox in Edge the scanning for files seems a hell of a job (empty progress bar, if thats a progress bar) nothing happens there. The "ID editor" and "SONOS" i didn't download and enable, i'll do that soon (only the "ID editor" and when i can use "SONOS"also with my Yamaha WX010 that one too).

@Rello
Copy link
Owner

Rello commented Dec 8, 2019

Hello @snarffy1959,
so did the scanner finish? can you play back all your files?

@snarffy1959
Copy link
Author

Hello @Rello, yes when using FireFox the scan finished (Edge not).

@snarffy1959 snarffy1959 reopened this Dec 8, 2019
@snarffy1959
Copy link
Author

@Rello, i had only one file, but that could be play backed . Thnx again for your reply, soon i'll have more files (files are on another lan, must see how i get them from there).

@Rello
Copy link
Owner

Rello commented Dec 8, 2019

Hello,
I just did a version check. ist seems the external getID3 library has some compatibility issues.
I will update everything and release a new version

@Rello Rello added this to the 2.9.0 milestone Dec 8, 2019
@snarffy1959
Copy link
Author

@Rello, then i wait. Is the new version "audioplayer_editor-0.1.1"?

@snarffy1959 snarffy1959 reopened this Dec 8, 2019
@Rello Rello changed the title Audio Player - PHP 7.4 PHP 7.4 compatibility Dec 8, 2019
@Rello Rello added testing and removed help wanted labels Dec 9, 2019
@mmatous
Copy link
Contributor

mmatous commented Dec 19, 2019

Running NC17 with PHP 7.4 is currently not officially supported. It's not listed here and support was added in this PR.

The cron.php (or whatever it is called) will fail unless you manually modify ./lib/versioncheck.php.

I am personally running 7.4 and it seems fine otherwise, but downgrading to 7.3 should be the preferred option until another NC update.

@snarffy1959
Copy link
Author

Thanx MMatous for your comment.

@Rello Rello modified the milestones: 2.9.0, 2.8.5 Dec 21, 2019
@Rello Rello modified the milestones: 2.8.5, 2.9.0 Dec 30, 2019
@Rello Rello closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants