Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player not loaded on shared folder #371

Closed
Ark74 opened this issue Jan 16, 2019 · 12 comments
Closed

Player not loaded on shared folder #371

Ark74 opened this issue Jan 16, 2019 · 12 comments
Assignees
@Rello
Labels
bug
Milestone
2.5.2

Comments

@Ark74
Copy link

Ark74 commented Jan 16, 2019

When an audio file is shared via link, it can't be played within the sharing page.

On Nextcloud 15.0.1
AudioPlayer 2.5.1
php-7.3.1

When clicking on a shared link with music, the audio is not played.

Console shows,

GET https://cloud.domain.com/apps/audioplayer/getpublicaudiostream?token=nrTRrodAykwBiNB&file=The%20song%20file.ogg net::ERR_ABORTED 500
nrTRrodAykwBiNB:1 Uncaught (in promise) DOMException

Seems that the requested stream requires js which can't be loaded thus the 500 error and no sound.
Cheers!
@Rello
Copy link
Owner

Rello commented Jan 16, 2019

Hello,

do you mean this player?
screen shot 2019-01-16 at 21 27 27

There is no audio-player-specific link anymore. It is using the stock-NC file link like https://testserver/nextcloud/s/S5X6xzGf8QoWWQs/download

can you please give some more information?

@Rello Rello self-assigned this Jan 16, 2019
@Rello Rello added needs info feedback from requester required sharing labels Jan 16, 2019
@Ark74
Copy link
Author

Ark74 commented Jan 16, 2019

No, I don't seem to have that.
Let me check closer, seems to be a SONOS player disable in my instance.

@Ark74
Copy link
Author

Ark74 commented Jan 16, 2019

No, the SONOS player doesn't allowme to pick any.
I only get this one when sharing a folder with music.
ap_shared

@Ark74
Copy link
Author

Ark74 commented Jan 16, 2019

Seems to work on individual files but not on folder shares. 🎧

@Rello
Copy link
Owner

Rello commented Jan 17, 2019

I will check. thank you for the sonos hint...

@Rello Rello added SONOS Issue with the SONOS feature and removed needs info feedback from requester required labels Jan 17, 2019
@Rello Rello mentioned this issue Jan 17, 2019
Closed
@Rello
Copy link
Owner

Rello commented Jan 17, 2019

Issue was located doe to a depreciated api
nextcloud/server#8853

@Rello Rello added bug in progress and removed SONOS Issue with the SONOS feature labels Jan 17, 2019
@Rello Rello added this to the 2.5.2 milestone Jan 17, 2019
Rello added a commit that referenced this issue Jan 17, 2019
@Rello
JS Player not loaded on shared folder. #371
e36a004
Rello added a commit that referenced this issue Jan 17, 2019
@Rello
JS Player not loaded on shared folder. #371
52ea91f
Rello added a commit that referenced this issue Jan 17, 2019
@Rello
JS Player not loaded on shared folder. #371
69435be
@Rello Rello added testing and removed in progress labels Jan 18, 2019
@Ark74
Copy link
Author

Ark74 commented Jan 18, 2019

Are these the changes to test,
e36a004

@Rello Rello changed the title JS Player not loaded on shared folder. Player not loaded on shared folder Jan 18, 2019
@Rello
Copy link
Owner

Rello commented Jan 18, 2019

yes.
I want to fix another minor thing and release 2.5.2 this weekend.
any pretest is appreciated...

@Ark74
Copy link
Author

Ark74 commented Jan 19, 2019

Tested on

  • Firefox @ latest
  • Google Chrome @ stable

both working.

@Rello
Copy link
Owner

Rello commented Jan 20, 2019

thank you for the quick reply!

@Rello
Copy link
Owner

Rello commented Jan 22, 2019

update released

@Rello Rello closed this as completed Jan 22, 2019
@C0rn3j
Copy link

C0rn3j commented Jan 22, 2019

Confirming fixed, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rello Rello

Labels
bug
Projects
None yet
Milestone
2.5.2
Development

No branches or pull requests
3 participants
@C0rn3j @Ark74 @Rello