Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not playing from shared subfolders #139

Closed
kknishev opened this issue Feb 10, 2017 · 11 comments
Closed

Not playing from shared subfolders #139

kknishev opened this issue Feb 10, 2017 · 11 comments
Assignees
Labels
Milestone

Comments

@kknishev
Copy link

Expected behavior

Play audio files from shared subfolders.

Actual behavior

Audio files (mp3) not playing from shared subfolders with permanent link:
SHARED_FOLDER\name.mp3 - OK
SHARED_FOLDER\folder\name.mp3 - NOK

From my admin account playing well in all case. But for users with shared link, playing from shared-root folder only. Help please.

Steps to reproduce the behavior

Possible solution (optional)

Server configuration

Operating system:
UBUNTU 16

Web server:
11.0.1

Database:
MSQL

PHP version:
7.0

ownCloud/Nextcloud version: (see /status.php)
NC 11.0.1

Updated from an older ownCloud/Nextcloud or fresh install:

Audio Player version: (see /settings/apps)
1.4.1

Where did you install Audio Player from:

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Client configuration

Operating system:
Windows10

Browser:
all

Logs

ownCloud/Nextcloud log

ownCloud/Nextcloud log (`/data/[owncloud|nextcloud].log`) ``` Insert your ownCloud/Nextcloud log here ```

Web server error log (optional)

Web server error log ``` Insert your webserver log here ```

Browser log (optional)

Browser error log JQMIGRATE: Migrate is installed, version 1.4.0 jquery-migrate.min.js (2,495) Missing plural form in language file _generatePluralFunction @ l10n.js:(99,4) publicpreview.php Failed to load resource: the server responded with a status of 404 (Not Found) 5DOgoitEpeUdSUc:1 Uncaught (in promise) DOMException: Failed to load because no supported source was found.
@Rello Rello self-assigned this Feb 26, 2017
@Rello Rello added the bug label Feb 26, 2017
@Rello
Copy link
Owner

Rello commented Feb 26, 2017

Hello,
issue is located.
the problem is that the subfolder is parsed with a "/" and this breaks the URL-scheme.

I will fix this...

https://.../owncloud/apps/audioplayer/getpublicaudiostreamSUBFOLDER/TITLE.mp3?token=vTKP1RJWNJXcG0d

@Rello Rello added this to the 1.5.0 milestone Feb 26, 2017
Rello added a commit that referenced this issue Feb 26, 2017
@Rello
Copy link
Owner

Rello commented Feb 26, 2017

the url scheme was corrected to a proper ?file= &token=

...next release.
thank you for reporting the finding!

@kknishev
Copy link
Author

Thanks a lot.
Try to fix my NC (correct 3 files), at list only two browser playing good:
Chrome - OK
Opera - OK

Firefox - NOK
IE - NOK
EDGE - NOK
:(

@ghost
Copy link

ghost commented Feb 26, 2017

We take a look at this. IE and Edge are not supported (see README.md and wiki).

@Rello
Copy link
Owner

Rello commented Feb 27, 2017

@kknishev can you send me the sharing link to audioplayer(at)scherello(dot)de for debugging?

Thank you

@kknishev
Copy link
Author

kknishev commented Feb 27, 2017 via email

@Rello
Copy link
Owner

Rello commented Feb 27, 2017

Hello @kknishev

I tested with FF 51.0.1 (64-Bit) and Chrome 56.0.2924.87 (64-bit) and the files in both folders are working for me.

do you have any error-code in FF?

@kknishev
Copy link
Author

FF 51.0.1 (32-bit)

Content Security Policy: Directive ‘frame-src’ has been deprecated. Please use directive ‘child-src’ instead. (unknown)
JQMIGRATE: Migrate is installed, version 1.4.0 jquery-migrate.min.js:2:542
Missing plural form in language file l10n.js:99:4
HTTP “Content-Type” of “text/html” is not supported. Load of media resource https://nextcloud.kknishev.ru/index.php/apps/audioplayer/getpublicaudiostream%D0%9D%D0%B0%D1%82%D0%B0%D0%BB%D1%8C%D1%8F%20%D0%9E%D0%A1%D0%98%D0%A1/2011%20%D0%A3%20%D1%81%D0%B0%D0%BC%D0%BE%D0%B3%D0%BE%20%D1%81%D0%B8%D0%BD%D0%B5%D0%B3%D0%BE%20%D0%BC%D0%BE%D1%80%D1%8F/00_00_Osis.mp3?token=5DOgoitEpeUdSUc failed. 5DOgoitEpeUdSUc
Cannot play media. No decoders for requested formats: text/html

@Rello
Copy link
Owner

Rello commented Feb 27, 2017

Please clear the cache of FF

Ist is still using the old url from the old JS file

@kknishev
Copy link
Author

Yep, thanks a lot, FF playing super good ;)
Is it anyways for IE/EDGE, in future may be?

@ghost
Copy link

ghost commented Feb 27, 2017

@kknishev Once again: We will not work on the compatibility with IE or Edge. Neither now nor in the near future!

@ghost ghost closed this as completed Feb 27, 2017
@ghost ghost locked and limited conversation to collaborators Mar 19, 2017
@ghost ghost reopened this Mar 19, 2017
@ghost ghost closed this as completed Mar 31, 2017
@ghost ghost removed the pending release label Mar 31, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants