Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image as album cover not written to DB - just to file #113

Closed
artemanufrij opened this issue Dec 30, 2016 · 6 comments
Closed

Image as album cover not written to DB - just to file #113

artemanufrij opened this issue Dec 30, 2016 · 6 comments
Assignees
Milestone

Comments

@artemanufrij
Copy link
Contributor

Expected behavior

Edit a title -> Set album cover -> Save -> Done

Actual behavior

Edit a title -> Set album cover -> Save -> Nothing happens

Steps to reproduce the behavior

  1. Open Edit Dialog
  2. Set a cover
  3. Choose "use as album cover"
  4. Save

Server configuration

Operating system:
Ubuntu Server 16.04

Web server:
Apache

Database:
SQLite

PHP version:
7

ownCloud/Nextcloud version: (see /status.php)
11 (Nextcoud)

Updated from an older ownCloud/Nextcloud or fresh install:
fresh install

Audio Player version: (see /settings/apps)
1.4.0

Where did you install Audio Player from:
'AppStore' (Nextcloud)

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Client configuration

Operating system:
Manjaro/Zorin/Solus

Browser:
Chrome / FireFox / IE11

@artemanufrij artemanufrij changed the title Can't set a image as album cover Can't set an image as album cover Dec 30, 2016
@Rello Rello added the bug label Dec 30, 2016
@Rello
Copy link
Owner

Rello commented Dec 30, 2016

Hello,
thank you for the feedback.
I had a look and there is a minor issue. Actually, the cover is written to the ID3-Tag of the file - but the display/database record is not updated correctly.

if you change a cover and would do a library reset&rescan, it would show.

I will have a look and fix it with the next release

@Rello Rello added this to the 1.4.1 milestone Dec 30, 2016
@Rello Rello self-assigned this Dec 30, 2016
@artemanufrij
Copy link
Contributor Author

Hey Rello,

it works. But this takes a long time. I have > 1000 titles.

Maybe it would be useful to display "cover.jpg / Cover.jpg / folder.jpg / Folder.jpg" if the file exists.

@Rello
Copy link
Owner

Rello commented Dec 31, 2016

hello,
as of 1.4.0 the cover/folder is being used during the scan when no ID3 image is found in the file.

for your issue: I will correct it, so the image is updated right away. does not make sense to trigger a rescan

@artemanufrij
Copy link
Contributor Author

Thank you!

Rello added a commit that referenced this issue Jan 15, 2017
#113
An old obsolete function for the backgroundcolor was called - and this caused the album not to be written.
Furthermore, when a cover was already set, it was not updated/overwritten
@Rello
Copy link
Owner

Rello commented Jan 15, 2017

Hello,

fix is implemented and will be released with the next version.
an old, obsolete function call caused an error and so the cover was not stored into the DB

@Rello Rello changed the title Can't set an image as album cover Image as album cover not written to DB - just to file Jan 15, 2017
@Rello Rello changed the title Image as album cover not written to DB - just to file fix: Image as album cover not written to DB - just to file Jan 15, 2017
@artemanufrij
Copy link
Contributor Author

Cool... Thank you! I use it every day

@ghost ghost closed this as completed Jan 22, 2017
@ghost ghost reopened this Jan 22, 2017
@ghost ghost removed the pending release label Jan 26, 2017
@ghost ghost closed this as completed Jan 26, 2017
@ghost ghost changed the title fix: Image as album cover not written to DB - just to file Image as album cover not written to DB - just to file Feb 12, 2017
@ghost ghost added the metadata label May 31, 2017
@ghost ghost added the metadata label Sep 23, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants