fix: correct arrays on nextcloud11 & php 7.1

[mc-comanescu]

Hi, these are a bunch of fixes that prevented my wife to create a brand new library ( fresh install ) from her disk files. All the bugs are in reference to php expecting an array() and instead getting a string.

ownCloud[2260]: {index} Exception: {"Exception":"Error","Message":"Cannot use string offset as an array","Code":0,"Trace":"
#0 \/var\/www\/owncloud\/apps\/audioplayer\/controller\/musiccontroller.php(160): OCA\\audioplayer\\Controller\\MusicController->loadSongs()
#1 [internal function]: OCA\\audioplayer\\Controller\\MusicController->getMusic()
#2 \/var\/www\/owncloud\/lib\/private\/AppFramework\/Http\/Dispatcher.php(160): call_user_func_array(Array, Array)
#3 \/var\/www\/owncloud\/lib\/private\/AppFramework\/Http\/Dispatcher.php(90): OC\\AppFramework\\Http\\Dispatcher->executeController(Object(OCA\\audioplayer\\Controller\\MusicController), 'getMusic')
#4 \/var\/www\/owncloud\/lib\/private\/AppFramework\/App.php(114): OC\\AppFramework\\Http\\Dispatcher->dispatch(Object(OCA\\audioplayer\\Controller\\MusicController), 'getMusic')
#5 \/var\/www\/owncloud\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php(47): OC\\AppFramework\\App::main('OCA\\\\audioplayer...', 'getMusic', Object(OC\\AppFramework\\DependencyInjection\\DIContainer), Array)
#6 [internal function]: OC\\AppFramework\\Routing\\RouteActionHandler->__invoke(Array)
#7 \/var\/www\/owncloud\/lib\/private\/Route\/Router.php(299): call_user_func(Object(OC\\AppFramework\\Routing\\RouteActionHandler), Array)
#8 \/var\/www\/owncloud\/lib\/base.php(1010): OC\\Route\\Router->match('\/apps\/audioplay...')
#9 \/var\/www\/owncloud\/index.php(40): OC::handleRequest()
#10 {main}","File":"\/var\/www\/owncloud\/apps\/audioplayer\/controller\/musiccontroller.php","Line":273}

[Rello]

Hello,
Thank you for the feedback.
Besides the mod of the getID3 they look good.
The external library cant be patched because it will be overwritten with the next update.

BUT: where did anything like that stop you from scanning a clean library?
They might return errors in the bckground during rhe first start - but these 2 controllers are not related to the scanner?!

[mc-comanescu]

Yes, They abort the php process running the script as they are considered syntax errors when they hit said section of the code. Once I rescan, the same file will be tried for re scanning and the script fails in the same spot. Thanks for the application tho. My wife is excited to find a music replacement app since that one was rejected when the fork happened.

…

On Wed, Dec 28, 2016 at 9:44 PM, Rello ***@***.***> wrote: Hello, Thank you for the feedback. Besides the mod of the getID3 they look good. The external library cant be patched because it will be overwritten with the next update. BUT: where did anything like that stop you from scanning a clean library? They might return errors in the bckground during rhe first start - but these 2 controllers are not related to the scanner?! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGMuIWIC8jW3e43AS44k6v1ACaejgtfuks5rMx6VgaJpZM4LXRmy> .

-- Mihail Comanescu

[Rello]

I will put them in - but they can not be the error in my opinion.
Musiccontroller is not called during scanning. Did you run occ?

[mc-comanescu]

Hi,
this is not triggered when running occ audioplayer:scan --all .
This is by going in the webgui -> app -> start scan route.
I suspect that said errors are a backward incompatibility with my environment.

PHP 7.1.0-5+deb.sury.org~yakkety+1 (cli) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.1.0-5+deb.sury.org~yakkety+1, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.5.0, Copyright (c) 2002-2016, by Derick Rethans

[Rello]

Ok. Then i know.
Because the gui will trigger the "album display" and this is when the music/categorycontroller are triggert.
So its not linked to the scan itself

Thank you!

[Rello]

thank you! @mc-comanescu