Improve Robustness of Data Load (empty data)

[dgedgedge]

I try to load the following data : https://raw.githubusercontent.com/owid/covid-19-data/master/public/data/vaccinations/vaccinations.csv

It's a csv file with multiple data for multiple countries.
When I try to load the data to have it as an internal data source, Colums 1,3,10 with analytics:load I get the following errors.
For me it is due to the fact that some data in this columns is empty.
I suggest to ptotect this behaviour by testing forhand that the data is a number before trying to insert it to tha database...

Note: Seeing this error I would ask if you did think to protect the code against SQL injection (from the data source) ?

occ analytics:load 12

In AbstractMySQLDriver.php line 106:
                                                                                                                                                                                                                                       
  An exception occurred while executing 'INSERT INTO `oc_analytics_facts` (`user_id`, `dataset`, `dimension1`, `dimension2`, `value`, `timestamp`) VALUES(?, ?, ?, ?, ?, ?)' with params ["xx", 25, "Albania", "2021-01-11", false  
  , 1613720978]:                                                                                                                                                                                                                       
                                                                                                                                                                                                                                       
  SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect decimal value: '' for column `nextcloud`.`oc_analytics_facts`.`value` at row 1                                                                                              
                                                                                                                                                                                                                                       

In PDOStatement.php line 129:
                                                                                                                                           
  SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect decimal value: '' for column `nextcloud`.`oc_analytics_facts`.`value` at row 1  
                                                                                                                                           

In PDOStatement.php line 127:
                                                                                                                                           
  SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect decimal value: '' for column `nextcloud`.`oc_analytics_facts`.`value` at row 1  
                                                                                                                                           

Note:
Nextcloud 20.0.7
Analytics 3.3.2
Debian GNU/Linux 10 (buster)
Mariadb...

[Rello]

Hi
Thank you for the report. Yes, there is still a lot of hardening to be done when the basics are implemented.
will get back...

[Rello]

Catch errors not to break everything - just skip incorrect records