You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just some thoughts I had after using the package for a new project, but too vague for actual issues:
use modern type syntax for properties: Collection<User> instead of Collection|User[]
use PSR-2 compliant code by default (indent with spaces)
camel case relationship methods
don't create models for pivot tables (or if you do, have them extend Pivot and not Model)
create factories as well
a v2 suggestion: don't destructively overwrite files – use reflection and/or token parsing to insert methods and properties when needed
Useful package for new projects, but definitely not something I would run again, mainly because of the last point. The workaround with 2 classes per model is clever but not very clean.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Just some thoughts I had after using the package for a new project, but too vague for actual issues:
Collection<User>
instead ofCollection|User[]
Pivot
and notModel
)Useful package for new projects, but definitely not something I would run again, mainly because of the last point. The workaround with 2 classes per model is clever but not very clean.
Beta Was this translation helpful? Give feedback.
All reactions