Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): have VersionWithRefresh depend on original data #516

Conversation

JosephKav
Copy link
Collaborator

convertedOriginal wasn't depending on the service data, so with the move from placeholder skeletons, to empty form, having the serviceID doesn't mean it can get the data. So the diff on refresh was comparing the form data with null, and so always sent the current form values as query params. This makes the refresh only happen on your browser session and does not trigger a version change in the backend.

@JosephKav JosephKav added bug Something isn't working javascript Pull requests that update Javascript code labels Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (757c716) to head (3246101).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         120      120           
  Lines       10279    10279           
=======================================
  Hits        10130    10130           
  Misses        121      121           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosephKav JosephKav merged commit 7d16750 into master Jan 15, 2025
7 checks passed
@JosephKav JosephKav deleted the 514-bug-the-ui-button-to-manually-refresh-the-deployed_version-doesnt-work-v2 branch January 15, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant