Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): style reformat #135

Merged
merged 30 commits into from
Aug 10, 2022
Merged

feat(config): style reformat #135

merged 30 commits into from
Aug 10, 2022

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Aug 8, 2022

Very large commit as the style formatting required changes in most places. And whilst I was doing that, I improved* some of the tests
This change shouldn't break existing config's. They will be converted, and when converted, saved. There may be a delay in the initial conversion startup if you have many (more than 32) services. It should take ~25s for every lot of 32 above 32. (serviceCount // 32 * 25 seconds)

  release-argus/Argus:
    comment: something
    options:
      active: false
      interval: 1h
      semantic_versioning: true
    latest_version:
      type: github
      url: release-argus/Argus
      access_token: TOKEN
      use_prerelease: false
      url_commands:
        - type: regex
          regex: "v?([0-9.]+)"
      require:
        regex_content: 'argus-{{ version }}.linux-amd64'
        regex_version: ^[0-9]+
    deployed_version:
      url: https://argus.something.io/api/v1/version
      allow_invalid_certs: true
      basic_auth:
        username: test
        password: 123
      Headers:
        - key: Authorization
          value: 'bearer hello'
      regex: '^[0-9]+$'
      json: version
    notify:
      - slack_id: {}
    command:
      - ['upgrade.sh', '{{service_id}}']
    webhook:
      - something: {}
    dashboard:
      auto_approve: true
      web_url: https://github.com/release-argus/Argus
      icon: https://github.com/release-argus/Argus/raw/master/web/ui/static/favicon.svg
      icon_link_to: https://argus.something.io

@JosephKav JosephKav added the enhancement New feature or request label Aug 8, 2022
@JosephKav JosephKav linked an issue Aug 8, 2022 that may be closed by this pull request
if l.GetAllowInvalidCerts() {
customTransport = http.DefaultTransport.(*http.Transport).Clone()
//#nosec G402 -- explicitly wanted InsecureSkipVerify
customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@JosephKav JosephKav force-pushed the 50-config-file-suggestions branch from 86e8aa8 to c5e909e Compare August 8, 2022 16:49
@JosephKav JosephKav force-pushed the 50-config-file-suggestions branch from f9c6ed7 to f7672b3 Compare August 8, 2022 17:46
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #135 (d3f7a39) into master (ced29f0) will increase coverage by 0.67%.
The diff coverage is 99.58%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   96.73%   97.39%   +0.67%     
==========================================
  Files          51       60       +9     
  Lines        4787     4939     +152     
==========================================
+ Hits         4630     4810     +180     
+ Misses        119       95      -24     
+ Partials       38       34       -4     
Impacted Files Coverage Δ
testing/commands.go 91.67% <ø> (-0.83%) ⬇️
testing/service.go 94.65% <ø> (-0.59%) ⬇️
testing/shoutrrr.go 96.63% <ø> (ø)
utils/util.go 100.00% <ø> (ø)
web/api/types/argus.go 100.00% <ø> (ø)
web/api/v1/websocket-client.go 85.54% <ø> (+4.18%) ⬆️
web/api/v1/websocket.go 92.71% <ø> (-0.46%) ⬇️
web/metrics/prometheus.go 100.00% <ø> (ø)
web/web.go 92.11% <ø> (-1.22%) ⬇️
webhook/announce.go 100.00% <ø> (ø)
... and 61 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@JosephKav JosephKav merged commit 5830e1a into master Aug 10, 2022
@JosephKav JosephKav deleted the 50-config-file-suggestions branch August 10, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config File Suggestions
1 participant