-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): style reformat #135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditch latest_version interfaces as unable to find a way to unmarshal a struct differently depending on type of 1 var
…/Argus into 50-config-file-suggestions
Closed
if l.GetAllowInvalidCerts() { | ||
customTransport = http.DefaultTransport.(*http.Transport).Clone() | ||
//#nosec G402 -- explicitly wanted InsecureSkipVerify | ||
customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check
InsecureSkipVerify should not be used in production code.
86e8aa8
to
c5e909e
Compare
f9c6ed7
to
f7672b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 96.73% 97.39% +0.67%
==========================================
Files 51 60 +9
Lines 4787 4939 +152
==========================================
+ Hits 4630 4810 +180
+ Misses 119 95 -24
+ Partials 38 34 -4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very large commit as the style formatting required changes in most places. And whilst I was doing that, I improved* some of the tests
This change shouldn't break existing config's. They will be converted, and when converted, saved. There may be a delay in the initial conversion startup if you have many (more than 32) services. It should take ~25s for every lot of 32 above 32. (
serviceCount // 32 * 25 seconds
)