Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming relay changes that will affect this plugin #46

Closed
jquense opened this issue Sep 16, 2019 · 2 comments
Closed

Upcoming relay changes that will affect this plugin #46

jquense opened this issue Sep 16, 2019 · 2 comments

Comments

@jquense
Copy link
Contributor

jquense commented Sep 16, 2019

Hey there 👋 Just wanted to give you a heads up that there are two changes in the pipe upstream, aimed at making integration better for webpack. I'm planning on sending a PR mkaing use of the changes, but thought it'd be neighborly to give you a heads up.

In particular the output change means, as is, the plugin won't write anything out now, since the changes go through the reporter. Hopefully this is a good thing tho since we can actually pipe those messages into webpack directly and let folks using webpack output plugins handle them.

The filesystem PR should give the opportunity to use webpacks fs wrapper which is heavily cached, should cut down on IO from disk and give a small speed improvement (hopefully)

@danielholmes
Copy link
Collaborator

@jquense Thanks for this. I'm a bit busy right now, but can probably get to this some time next week

@taion
Copy link
Member

taion commented Nov 8, 2019

I think we can close this out now.

@jquense jquense closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants