Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove golang.org/x/exp dependency when Go 1.23 is released #115

Open
meling opened this issue Mar 9, 2024 · 0 comments
Open

Remove golang.org/x/exp dependency when Go 1.23 is released #115

meling opened this issue Mar 9, 2024 · 0 comments
Assignees
@meling
Labels
enhancement New feature or request

Comments

@meling
Copy link
Member

meling commented Mar 9, 2024 •
edited
Loading

In cmd/latencygen/latency_gen.go:32 we can replace these two lines:

keys := maps.Keys(allToAllMatrix)
sort.Strings(keys)

With this line:

keys := slices.Sorted(maps.Keys(allToAllMatrix))

When Go 1.23 is released with support for rangefunc. See golang/go:#61538 for additional context and golang/go:#61900 for the accepted proposal.

Similar updates needs to be done in crypto/cache.go and twins/network.go.
@meling meling added the enhancement New feature or request label Mar 9, 2024
@meling meling self-assigned this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meling meling

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meling