-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait_for_migrators not working anymore #1595
Comments
The first migration in the chain has now been fully closed, and the bot still does not advance |
This will require some debugging of the migrator by hand I bet. I am not sure when I'll have time to get to it. |
OK, thanks. Could we please merge conda-forge/conda-forge-pinning-feedstock#4003 in the meantime? |
Do you have a current example where this is broken? |
See conda-forge/conda-forge-pinning-feedstock#4003 (the respective migrators did not get triggered even though all the ancestors had been built) |
Right sorry. I need a current ongoing migration where things look busted and the wait for migrators is set. To debug the code I need the live state of the bot. |
Hey all
I just noticed that
wait_for_migrators:
doesn't seem to work as intended anymore.For background: the aws-c-* ecosystem has a lot of small migrations, and letting them run at the same time -- e.g. when someone comes and merges the bot PRs in the pinning repo -- means that some migrations end up getting blocked by a diamond-shaped upgrade race condition between the bots. For this reason, it's very convenient to chain them together using
wait_for_migrators
, and then they used to run through on auto-pilot (here's an example from November 2022 where this worked).I now did the same in conda-forge/conda-forge-pinning-feedstock#3991, but even though the first migration is fully done, the status bot thinks all feedstocks of the following migrator are "waiting for parents" (see status page).
I had a look at the most recent changes here (#1517, a while ago), and also looked at the most recent migrator run, where I cannot even find the phrase "need to wait for" that should be added by the logger (or maybe it's not shown because debug-level logging is not shown by default?).
Would be nice if we could keep using this feature.
CC @isuruf @becker @jakirkham
The text was updated successfully, but these errors were encountered: