Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ko_kr translation #49

Conversation

gisellevonbingen
Copy link
Contributor

@gisellevonbingen gisellevonbingen commented Dec 24, 2023

Tried refined the sentences naturally.
Thanks. ❤️

@raoulvdberge
Copy link
Collaborator

Hello, can you rebase your branch on the latest version of develop please?

@gisellevonbingen
Copy link
Contributor Author

Did you mean like this?

image

@raoulvdberge
Copy link
Collaborator

Hello, yes, please check the failed checks.

  • Please fix the commit message format (rename commit)
  • Please add a changelog entry.

@raoulvdberge
Copy link
Collaborator

Unfortunately, merge commits aren't allowed. Please rebase

@raoulvdberge
Copy link
Collaborator

Also, don't link github issue numbers in the changelog.

@gisellevonbingen
Copy link
Contributor Author

gisellevonbingen commented Mar 10, 2024

Oops.. i see..

@gisellevonbingen
Copy link
Contributor Author

Changed

@raoulvdberge
Copy link
Collaborator

You updated the wrong changelog entry. It has to be under "Unreleased", not under an already released version

@gisellevonbingen
Copy link
Contributor Author

Oh, you right.

@raoulvdberge
Copy link
Collaborator

raoulvdberge commented Mar 10, 2024

And now just add a heading (### Changed) and it's complete.

@gisellevonbingen
Copy link
Contributor Author

yes it done.

@raoulvdberge raoulvdberge enabled auto-merge March 10, 2024 13:54
@raoulvdberge
Copy link
Collaborator

Thanks!

@raoulvdberge raoulvdberge merged commit ac74ec1 into refinedmods:develop Mar 10, 2024
4 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants