Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects with values stored don't return the whole array #5

Open
ReeceM opened this issue Aug 23, 2019 · 1 comment
Open

Objects with values stored don't return the whole array #5

ReeceM opened this issue Aug 23, 2019 · 1 comment
Labels
enhancement New feature or request in review

Comments

@ReeceM
Copy link
Owner

ReeceM commented Aug 23, 2019

When a object is assigned to a value e.g.:

$mocked->value['sub_value'] = 'stripes'

echo $mocked->value;
// returns 
// mocked->value

What would be nicer is that when the value is called with __toString() which triggers that reaction of printing a formatted

[
    "sub_value" => 'stripes'
]

or if the values is just called by the magic __get it should return the value as a php array type, instead of assuming that it may be calling another dynamically generated value.

@ReeceM ReeceM added enhancement New feature or request in review labels Aug 23, 2019
@ReeceM ReeceM added the hacktoberfest for the 2019 hacktoberfest label Oct 2, 2019
@ReeceM ReeceM removed the hacktoberfest for the 2019 hacktoberfest label Dec 27, 2019
@ReeceM
Copy link
Owner Author

ReeceM commented Jun 14, 2020

Actually this was fixed by #15 ... the toString returns the JSON array, can make it be JSON_PRETTY 😝 lol, but still this >

or if the values is just called by the magic __get it should return the value as a php array type, instead of assuming that it may be calling another dynamically generated value.

is an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in review
Projects
None yet
Development

No branches or pull requests

1 participant