From 18ab40c44a1dfeb4babd9a17f40f1f9e9256ea43 Mon Sep 17 00:00:00 2001 From: Daniel Choudhury Date: Thu, 4 Mar 2021 12:06:51 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Peter Pistorius --- .eslintrc.js | 1 - tasks/test-tutorial.js | 14 ++++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 98ed1654543f..c032631bed11 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -97,7 +97,6 @@ module.exports = { 'packages/testing/src/**', 'packages/eslint-config/*.js', 'packages/eslint-plugin-redwood/src/**', - 'tasks/**', ], env: { es6: true, diff --git a/tasks/test-tutorial.js b/tasks/test-tutorial.js index cd65147e33e2..84679330261e 100644 --- a/tasks/test-tutorial.js +++ b/tasks/test-tutorial.js @@ -1,3 +1,5 @@ +/* eslint-env node, es6*/ + import fs from 'fs' import os from 'os' import path from 'path' @@ -25,10 +27,11 @@ const testTutorial = async () => { }) if (pathToProject) { - console.log( - `\n 🗂ī¸ You have supplied the path ${projectPath}, we will not create a new ` - ) - console.log('Redwood project, we will use the app you have specified.') + console.log([ + '🗂ī¸ You have supplied the path "${projectPath}",' + 'because of this we assume that there is a pre-existing Redwood project at this path,' + 'so we will not create a new redwood project.' + ].join('\n')) } else { console.log('\n ℹī¸ You have not supplied a path to a Redwood project.') console.log('We will create one for you. \n \n') @@ -39,6 +42,7 @@ const testTutorial = async () => { // Use temporary project path, because no user supplied one projectPath = fs.mkdtempSync(path.join(os.tmpdir(), 'redwood-e2e-')) + console.log('------------------------ start create redwood app -------------------------') await execa( 'yarn babel-node', ['src/create-redwood-app.js', projectPath, '--no-yarn-install'], @@ -49,6 +53,8 @@ const testTutorial = async () => { } ) } + + // Clean and build framework await execa('yarn build:clean && yarn lerna run build:js', {