Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSandbox from Redux Essentials, Part 5 documentation not functional #4212

Closed
jasonsturges opened this issue Nov 5, 2021 · 2 comments
Closed

Comments

@jasonsturges
Copy link

jasonsturges commented Nov 5, 2021

What docs page needs to be fixed?

Redux Essentials, Part 5: Async Logic and Data Fetching

What is the problem?

CodeSandbox is not functional:

Unexpected token < in JSON at position 0

image

What should be changed to fix the problem?

Presumably the API faker for authors is not returning expected result?

It might be a race condition, as once I start editing the sandbox the issue is resolved during live update.

@markerikson
Copy link
Contributor

Yeah, this may be due to an issue we'd noted with the startup logic for the msw API mocking lib. The index file should really be doing await worker.start(), but instead it's just doing worker.start() and continuing. I haven't had a chance to go back and rewrite the repo's history to make that change.

@markerikson
Copy link
Contributor

Should be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants