Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs: Rewrite] Unexplained switch to separate <PostExcerpt> component usage #4000

Closed
sysrage opened this issue Jan 22, 2021 · 2 comments
Closed

Comments

@sysrage
Copy link

sysrage commented Jan 22, 2021

What docs page needs to be fixed?

  • Section: Redux Essentials
  • Page: Async Logic and Data Fetching

What is the problem?

In the section "Displaying Loading State", the example code suddenly switches to using <PostExcerpt>, but that wasn't used in the last set of instructions where this portion of code is used. Anybody following-along the guide is forced to scroll to the bottom of this section to open the code sandbox and see exactly how the <PostExcerpt> component is built. The code sandbox from the previous section didn't include <PostExcerpt> as a separate component.

Users can ignore this and continue using the single-component layout, but it makes things a bit confusing when they get to the profiling section and don't see a separate <PostExcerpt> component. It also makes it difficult to then wrap React.memo() around it.

What should be changed to fix the problem?

Use the separate <PostExcerpt> component in the previous section.

@markerikson
Copy link
Contributor

Hmm. I know I went back and forth on whether to have that component a few times while writing the tutorial. It's very possible that I didn't end up showing that one clearly.

@markerikson
Copy link
Contributor

Resolved by #4153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants