-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: split redux-react into a separate package #230
Comments
One thing I want to be able to do is to make breaking changes to |
It's worth noting it's possible to do it the other way: move core to |
👍 (to the first suggestion) |
Perhaps it's just personal preference, but I'm more often annoyed by too much coupling versus too much splitting, and would prefer to err on the modular side. |
This not makes sense for me because it makes harder to maintain projects written using redux. At least we'll have to track versions for both packages, instead of one. |
@nkt It's only two packages :) |
I've never understood that complaint about Babel. The version numbers for |
I could not have said it better myself.
I like this proposal 👍 |
At the moment I only plan to use Redux with React, but splitting out React-specific code sounds like the right architectural thing to do. |
@gaearon I suggest you to wait a little. If after all maintaining single package become real pain you can split it. |
@gyzerok, agree your call. |
IMO doing this move as part of 1.0 stable makes sense. This is kind of a breaking change, so the timing seems to be just right. |
But this will be a breaking change in itself which will force us to jump to 2.0. (And we are: these libraries have very little in common.) |
If somebody wants to start setting up |
I started redux-react project here: https://github.com/gaearon/redux-react. The tests are green. After I make the initial release of it, I'll remove React bindings from Redux in 1.0 breaking changes branch. |
This is done now, so closing. |
I'm not a fan of over-splitting.
However we already export React-specific parts separately (
redux/react
andredux/react-native
). React also embraces some splitting in React 0.14 (react
andreact-dom
). It's becoming harder to buy the argument that people mind splitting so much.I've heard complaints that people don't understand what is “core” to Redux and what is not because of
Provider
andConnector
baked into Redux. I've also heard people want to use Redux with Ember, Angular 2 and Deku. There is a work in progress on an Angular 2 example project.Things like
Provider
andConnector
are React-specific and there also may be better ways to write them. It's harder to focus on developing them (and maybe bringing in additional functionality) when they're right inside the core. At this point there's so little API that binds them together (basically{ getState, dispatch, subscribe }
is their only common point) that I think splitting might bring more benefits than inertia and/or management overhead.Here's my proposal:
reduxjs
orgredux-react
andredux-react-native
redux-react-native
altogetherWe'll also see if there is interest in “blessed” Angular/Ember bindings, and people willing to maintain them.
Thoughts?
The text was updated successfully, but these errors were encountered: