You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Will be working on a PR to update all variables today. It also seemed that there is interest in adding in semicolons. I could do that as well, any thoughts?
The text was updated successfully, but these errors were encountered:
I'm okay with a change from var to let/const, as it's reasonable for consistency given that we're using ES6 throughout the codebase. That said, although my own personal preference is to use semicolons, I'm also not keen on touching entire codebases just to update styles. Tends to make git blame rather useless. So, at this time I'd prefer to not introduce semicolons just for the sake of having semicolons.
Currently redux uses pre-ES6 variable assignment, as shown here. Per @gaearon it was due to flow failing on let/const a long time ago. The issue is no longer relevant now.
Will be working on a PR to update all variables today. It also seemed that there is interest in adding in semicolons. I could do that as well, any thoughts?
The text was updated successfully, but these errors were encountered: