Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable assignment to ES6 usage #2168

Closed
davidrbright opened this issue Dec 26, 2016 · 2 comments
Closed

Update variable assignment to ES6 usage #2168

davidrbright opened this issue Dec 26, 2016 · 2 comments

Comments

@davidrbright
Copy link
Contributor

Currently redux uses pre-ES6 variable assignment, as shown here. Per @gaearon it was due to flow failing on let/const a long time ago. The issue is no longer relevant now.

Will be working on a PR to update all variables today. It also seemed that there is interest in adding in semicolons. I could do that as well, any thoughts?

@markerikson
Copy link
Contributor

Hi, thanks for following up on this.

I'm okay with a change from var to let/const, as it's reasonable for consistency given that we're using ES6 throughout the codebase. That said, although my own personal preference is to use semicolons, I'm also not keen on touching entire codebases just to update styles. Tends to make git blame rather useless. So, at this time I'd prefer to not introduce semicolons just for the sake of having semicolons.

@davidrbright
Copy link
Contributor Author

Okay thanks for letting me know. I'll skip the semicolons as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants