Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back HOCs on top of the container components #14

Closed
gaearon opened this issue Jun 3, 2015 · 4 comments
Closed

Bring back HOCs on top of the container components #14

gaearon opened this issue Jun 3, 2015 · 4 comments
Labels
enhancement

Comments

@gaearon
Copy link
Contributor

gaearon commented Jun 3, 2015

As per #5 (comment), let's bring back HOCs, but this time built on top of the container components. Container components are lower level.

This work would include:

  • Change root to be a container component called Root
  • Implement root and container as HOCs that wrap the components
  • I want to keep using root HOC + Container component in the examples
  • Tricky file naming. I guess let's put them into addons folder but keep root etc as the export name.

@hugobessaa
@ooflorent
Copy link
Contributor

See #15. I does not fully cover your list be may be a start.

@gaearon
Copy link
Contributor Author

gaearon commented Jun 3, 2015

Oh, cool. Can you please bring this up to date with the todo list in this issue?

@hugooliveirad
Copy link

You were too fast. I'm commuting 🚀

Let us know if you want help implementing the other things in the todo list

@gaearon
Copy link
Contributor Author

gaearon commented Jun 3, 2015

Done now.

@gaearon gaearon closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ooflorent @gaearon @hugooliveirad