Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Tutorial code errors #800

Closed
iakovosvo opened this issue Nov 10, 2020 · 4 comments
Closed

Advanced Tutorial code errors #800

iakovosvo opened this issue Nov 10, 2020 · 4 comments

Comments

@iakovosvo
Copy link

iakovosvo commented Nov 10, 2020

There are several errors in the codesandbox of this tutorial. Starting with Cannot read property 'replace' of null in /src/utils/stringUtils.ts:10:23

@markerikson
Copy link
Collaborator

Long-term, this ties into the need to rewrite the tutorials over in #371 , but that's very low on my priority list atm.

Unfortunately, this isn't just a simple easy fix. The sandboxes currently point to very specific commits, and redoing them means:

  • cloning the tutorial repo
  • resetting the tutorial branch back to wherever the problem started
  • fixing up the problem commit
  • cherry-picking all existing commits
  • Updating the entire tutorial (sandboxes and commit links) to point to the newly generated commit IDs

I don't have time to do that right now.

If this only affects the tail end of the tutorial, the short-term fix might be to file a PR to fix up the the example repo, and update the embed link on the (hopefully just one?) sandbox that's showing this error.

If someone else would like to tackle this, please do so.

@leosuncin
Copy link

I can give it a try

@markerikson
Copy link
Collaborator

Please do, thanks! Let me know if you have any issues/questions with trying to fix things up.

Frankly, it would be a very good thing if we could at least update the tutorial text and sandbox embeds to point to tags, instead of commit IDs. That would simplify the process if we ever need to tweak this again.

You can see how I did that with the new "Essentials/Fundamentals" tutorials over in the Redux core docs.

@markerikson
Copy link
Collaborator

Obsolete due to #905 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants