You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have often found myself wishing that a component's own props were available in the areStatesEqual method. I usually use an immutable.js store and convert to plain JS objects while mapping (which can potentially be expensive) and use areStatesEqual to prevent mapping unnecessarily. I am also sometimes using a property of the component to slice off a subsection of the state which leads me to wish I could sometimes do something like this:
Does anybody else encounter/wish for this? Is there a philosophical reason this shouldn't be done? Looking at the code it appears it would be trivial to make this change. I thought it best I should check before opening a pull request.
The text was updated successfully, but these errors were encountered:
I have often found myself wishing that a component's own props were available in the
areStatesEqual
method. I usually use an immutable.js store and convert to plain JS objects while mapping (which can potentially be expensive) and useareStatesEqual
to prevent mapping unnecessarily. I am also sometimes using a property of the component to slice off a subsection of the state which leads me to wish I could sometimes do something like this:Does anybody else encounter/wish for this? Is there a philosophical reason this shouldn't be done? Looking at the code it appears it would be trivial to make this change. I thought it best I should check before opening a pull request.
The text was updated successfully, but these errors were encountered: