Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of Object.defineProperty breaks ie8 again #227

Closed
xcatliu opened this issue Dec 23, 2015 · 3 comments
Closed

use of Object.defineProperty breaks ie8 again #227

xcatliu opened this issue Dec 23, 2015 · 3 comments

Comments

@xcatliu
Copy link

xcatliu commented Dec 23, 2015

At #133, we fixed the issue within v3.1.0.

But it appears again in v4.0.3.

Here is the file lib/index.js in v3.1.0 and v4.0.3.

v3.1.0

'use strict';

exports.__esModule = true;

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { 'default': obj }; }

var _react = require('react');

var _react2 = _interopRequireDefault(_react);

var _componentsCreateAll = require('./components/createAll');

var _componentsCreateAll2 = _interopRequireDefault(_componentsCreateAll);

var _createAll = _componentsCreateAll2['default'](_react2['default']);

var Provider = _createAll.Provider;
var connect = _createAll.connect;
exports.Provider = Provider;
exports.connect = connect;

v4.0.3

'use strict';

exports.__esModule = true;

var _Provider = require('./components/Provider');

Object.defineProperty(exports, 'Provider', {
  enumerable: true,
  get: function get() {
    return _Provider.default;
  }
});

var _connect = require('./components/connect');

Object.defineProperty(exports, 'connect', {
  enumerable: true,
  get: function get() {
    return _connect.default;
  }
});
@xcatliu
Copy link
Author

xcatliu commented Dec 23, 2015

It seems to be a problem with babel@6.

What .babelrc should we set to avoid the use of defineProperty?

@gaearon
Copy link
Contributor

gaearon commented Dec 23, 2015

Sorry for screwing this up. Should be fixed in 4.0.4.

@xcatliu
Copy link
Author

xcatliu commented Dec 23, 2015

@gaearon Thanks! Works fine with v4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants